Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python setup.py --help-commands not working #184

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Fix python setup.py --help-commands not working #184

merged 1 commit into from
Feb 26, 2018

Conversation

althonos
Copy link
Contributor

With the current green version installed:

python setup.py --help-commands
usage: green [options] [target [target2 ...]]
green: error: unrecognized arguments: --help-commands

This is a mistake of mine, as generating the argument list for green.command.green actually parses the CLI arguments beforehand, and since it does not know --help-commands, the program crashes.

I also changed the description to be more in par with the other tools:

  • behave description: Run feature tests with behave
  • nosetests description: Run unit tests using nosetests

so I changed green description to Run unit tests using green.

@CleanCut CleanCut merged commit 7008a67 into CleanCut:master Feb 26, 2018
@CleanCut
Copy link
Owner

Thanks!

@althonos
Copy link
Contributor Author

@CleanCut: I didn't even see there was an issue about this in the issue tracker ! :)

@CleanCut
Copy link
Owner

No way! I thought you were addressing that specifically because you saw it!

@CleanCut
Copy link
Owner

Included in 2.12.1 -- just released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants