-
-
Notifications
You must be signed in to change notification settings - Fork 51
Making easy to use some features #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CleanCut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I think these are great as additional features!
I do not feel that these are easier to use than the existing features, so I have reverted most of the examples, leaving a commented-out example in examples/keyboard_state.rs as a teaser. I feel like this is a nice "discoverable" feature for more advanced/ambitious students.
Question: I noticed that in your own conversion of the examples, you never needed to make use of the &MouseState or &KeyboardState that you passed to the closure. Are you certain that you don't want to remove that parameter? I wouldn't need it for the simple scenarios I lead students through, but perhaps you find it useful? If you would like to make that change, I'll wait for you. If you like it how it is, I'll go ahead and merge this now. Let me know!
Anyway, I love your all lectures on Udemy. Teacher Nathan! I recently started |
|
The &mut Engine is now available in the closures... And I removed the method name The argument in the closure,
|
…ressed[_any](..) now you can use &mut Engine inside the closure
8be6a1f to
41db2aa
Compare
|
Alright, I left the reference parameters in. I tweaked the names a little bit. I renamed |
|
Included in version |
No description provided.