Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogisticsPipe Patch: singlethread classLoad #70

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

VSMPNR
Copy link
Contributor

@VSMPNR VSMPNR commented Dec 12, 2024

Replace parallelStream() with stream() and run with a single thread.

@kappa-maintainer
Copy link
Collaborator

Does it fix the error in definePackage()? Could this maintain the same performance level as original code? If so, there's no need to keep the current class preload transformer

@VSMPNR
Copy link
Contributor Author

VSMPNR commented Dec 13, 2024

It probably works because it starts without ClassNotFoundException even in an environment where errors occur with a high probability.
Considering the amount of classes loaded, I don't think there is a significant difference in performance between parallelStream() and stream().
I didn't notice any change in boot time.

  • launch test environment
    • Physical memory: 16gb
    • Virtual memory(windows swap file): 64gb
    • jvm minuum memory : 32gb
    • jvm maxium memory : 32gb

@kappa-maintainer kappa-maintainer merged commit ce160db into CleanroomMC:master Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants