Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config to prevent minifying svg stripping IDs #7

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Add config to prevent minifying svg stripping IDs #7

merged 1 commit into from
Jun 8, 2023

Conversation

michaellisitsa
Copy link
Contributor

@michaellisitsa michaellisitsa commented Jun 7, 2023 •
edited by CubedEye
Loading

  • [Fixes] Issue was id was parcel by default minifies svg, and strips ids and causes other issues.

See parcel-bundler/parcel#1523 (comment)

NOTE When testing, make sure to clear your .parcel-cache folder before running / compiling.

@michaellisitsa michaellisitsa requested a review from a team June 7, 2023 05:47
@ClearCalcs ClearCalcs deleted a comment from michaellisitsa Jun 8, 2023
@CubedEye CubedEye merged commit cf0c5cd into main Jun 8, 2023
@CubedEye CubedEye deleted the prevent-parcel-stripping-svg-attributes branch June 8, 2023 14:18
@CubedEye CubedEye changed the title Add config to prevent minifying svg stripping ids #860r0wdec Add config to prevent minifying svg stripping ids Jun 10, 2023
@CubedEye CubedEye changed the title Add config to prevent minifying svg stripping ids Add config to prevent minifying svg stripping IDs Jun 10, 2023
@ClearCalcs ClearCalcs deleted a comment from michaellisitsa Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CubedEye CubedEye CubedEye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaellisitsa @CubedEye