Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi IMU #32

Merged
merged 10 commits into from
Aug 31, 2022
Merged

Conversation

rfvermut
Copy link
Collaborator

See commits for changes

@rfvermut rfvermut force-pushed the feat/multi-imu-drc_erc branch from cbdbaa1 to a61f026 Compare August 28, 2022 19:56
@ClemensElflein
Copy link
Owner

Thank you for the PR!

  • There are some issues I found with the connections of the Pico: GP6 is SCK, but used as MOSI, 7 is MOSI and it's used as clock and so on.
  • Could we make the naming for GPIO8 and GPIO9 in a way that we can see that these are used in duplicate functions (e.g. SP_MISO_UART_TX for GPIO8)
  • Could you please rename GPIO16 and GPIO17 with something like SOUND_TX and SOUND_RX, it's a serial connection now. It used to be for another sound module which used another protocol.

Everything else looks good to me.

@ClemensElflein
Copy link
Owner

@ClemensElflein
Copy link
Owner

Thank you for the update, looks good to me!

@ClemensElflein ClemensElflein merged commit 39c12b3 into ClemensElflein:main Aug 31, 2022
@rfvermut rfvermut deleted the feat/multi-imu-drc_erc branch March 20, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants