Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for CoverUI's "with Display" Proposal #78

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

Apehaenger
Copy link
Contributor

Issue

When porting a stock CoverUI with some kind of display (instead of simple LEDs), it's currently required to translate the LED states (on, off, blink_slow, blink_fast) back to some kind a displayable value.
This is somehow cumbersome as well as inaccurate (i.e. charging state is currently represented by one LED).

Because updating the CoverUI is painful (you've to open the mower), it's required to find a solution which doesn't influence current implementations in any way.

Approach

Implement some kind of request which has to be initiated by the CoverUI's FW which is interested in other data than the current Set_LEDs packet.

Implementation

For this, I added the msg_event_subscribe packet, which can be requested by the CoverUI to "subscribe" to specific data. Default to Set_LEDs packet, so that current installations work as before.

Summary

This is a proposal. Nothing tested yet.
Like to know you thoughts.
As I expect to get two more stock CoverUI's the next days, and one will have a display again, I like to find a solution which is clear and stable for some longer time.

@Apehaenger Apehaenger changed the title Proposal Better support fpr CoverUI's "with Display" Proposal Oct 12, 2023
@Apehaenger Apehaenger changed the title Better support fpr CoverUI's "with Display" Proposal Better support for CoverUI's "with Display" Proposal Oct 12, 2023
@Apehaenger
Copy link
Contributor Author

Implemented CoverUI- subscription functionality in Stock- SAxPRO model, and tested with and without subscription, also with C500B and RM-ECOW-V1.0.0 (NX80i) CoverUIs.
Works as expected.
Would be cool if it could be merged as it's required now for SAxPRO and will also be required by (future) NX100i CoverUI port.

@Apehaenger Apehaenger marked this pull request as ready for review November 14, 2023 16:16
@ClemensElflein
Copy link
Owner

LGTM, thank you for the PR.

@ClemensElflein ClemensElflein merged commit 87cdaad into ClemensElflein:main Mar 10, 2024
@Apehaenger Apehaenger deleted the feature/subscribe branch March 11, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants