-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/fix ci #165
Chore/fix ci #165
Conversation
Requesting review from @docgalaxyblock and @Apehaenger because you both worked on the CI issue. @docgalaxyblock says its a good idea to keep the builder on (Also specifying is a good idea, because on Discord we had some confusion about formatting rules with differing clang-format versions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also prefer to go with -latest instead of getting antique by time.
In fact I also tried to examine how, but all I found, sound wired (like set to python@3
instead of python@3.x.x
), so I ugly switched to ubuntu-22.04 because it was obvious that the new -latest (24.x) was the reason for the failing CI.
Specifying the clang-format version is also preferable, even though I couldn't identify what really happen in the discussed issue at Discord. But similar already happen before #141 (comment)
I'm unsure about if you didn't already tested switching the auth username to github.actor
during last try, but I even don't know how to test without merging 😇
OK give it a short check and my commits are already included in #152 where the I would remove all commits except 28e4b38 and then add my discovered fixes for the 24.04/latest based runner. Edit: like here |
e10e7f2
to
37025bc
Compare
force pushed your linked commits to this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the Workflow also succeeded.
No description provided.