Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/fix ci #165

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Chore/fix ci #165

merged 2 commits into from
Oct 19, 2024

Conversation

ClemensElflein
Copy link
Owner

No description provided.

@ClemensElflein
Copy link
Owner Author

ClemensElflein commented Oct 17, 2024

Requesting review from @docgalaxyblock and @Apehaenger because you both worked on the CI issue. @docgalaxyblock says its a good idea to keep the builder on -latest, but the clang-format failed due to version mismatch, this seems to fix it.

(Also specifying is a good idea, because on Discord we had some confusion about formatting rules with differing clang-format versions)

Copy link
Collaborator

@Apehaenger Apehaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also prefer to go with -latest instead of getting antique by time.
In fact I also tried to examine how, but all I found, sound wired (like set to python@3 instead of python@3.x.x), so I ugly switched to ubuntu-22.04 because it was obvious that the new -latest (24.x) was the reason for the failing CI.

Specifying the clang-format version is also preferable, even though I couldn't identify what really happen in the discussed issue at Discord. But similar already happen before #141 (comment)

I'm unsure about if you didn't already tested switching the auth username to github.actor during last try, but I even don't know how to test without merging 😇

@docgalaxyblock
Copy link
Collaborator

docgalaxyblock commented Oct 17, 2024

OK give it a short check and my commits are already included in #152 where the github.actor did not worked and I therefore force-pushed the commit out again.

I would remove all commits except 28e4b38 and then add my discovered fixes for the 24.04/latest based runner.

Edit: like here

@ClemensElflein
Copy link
Owner Author

force pushed your linked commits to this pr

Copy link
Collaborator

@docgalaxyblock docgalaxyblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the Workflow also succeeded.

@ClemensElflein ClemensElflein merged commit ac81497 into main Oct 19, 2024
3 checks passed
@ClemensElflein ClemensElflein deleted the chore/fix-ci branch October 19, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants