Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to use "--change_memory_prefix" #1375

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

GrecuAlexandru
Copy link

@GrecuAlexandru GrecuAlexandru commented Jan 8, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Added possibility to use "--change_memory_prefix" flag to see the RAM memory in one of the following prefixes: KiB, MiB, GiB, TiB. You can either pass one of those or "auto" which was the default setting.

Issue

If applicable, what issue does this address?
Added the request provided here: #695 and #696

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (0f969fc) 32.37% compared to head (1c2a7d0) 32.36%.
Report is 17 commits behind head on main.

❗ Current head 1c2a7d0 differs from pull request most recent head f14993a. Consider uploading reports for the commit f14993a to get more accurate results

Files Patch % Lines
src/bin/main.rs 0.00% 16 Missing ⚠️
src/data_conversion.rs 0.00% 16 Missing ⚠️
src/data_collection.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
- Coverage   32.37%   32.36%   -0.02%     
==========================================
  Files          98       98              
  Lines       17227    17258      +31     
==========================================
+ Hits         5577     5585       +8     
- Misses      11650    11673      +23     
Flag Coverage Δ
macos-12 34.20% <18.18%> (-0.02%) ⬇️
ubuntu-latest 33.93% <18.18%> (-0.02%) ⬇️
windows-2019 34.25% <18.18%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang
Copy link
Owner

Hm, not sure if I prefer it as a single flag for only mega, it would probably make more sense IMO to take an argument with the value being the unit (e.g. MiB, KB, etc.).

@GrecuAlexandru GrecuAlexandru changed the title Added possibility to use "--memory_use_mega_prefix" Added possibility to use "--change_memory_prefix" Jan 23, 2024
@ClementTsang
Copy link
Owner

Shoot, didn't notice the updates to this PR - I can rebase and review in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants