-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added possibility to use "--change_memory_prefix" #1375
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1375 +/- ##
==========================================
- Coverage 32.37% 32.36% -0.02%
==========================================
Files 98 98
Lines 17227 17258 +31
==========================================
+ Hits 5577 5585 +8
- Misses 11650 11673 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hm, not sure if I prefer it as a single flag for only mega, it would probably make more sense IMO to take an argument with the value being the unit (e.g. MiB, KB, etc.). |
Shoot, didn't notice the updates to this PR - I can rebase and review in a bit. |
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Added possibility to use "--change_memory_prefix" flag to see the RAM memory in one of the following prefixes: KiB, MiB, GiB, TiB. You can either pass one of those or "auto" which was the default setting.
Issue
If applicable, what issue does this address?
Added the request provided here: #695 and #696
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)