Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add the ability to configure the disk widget's table columns #1625

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Nov 18, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Adds the ability to specify the process widget's columns.

For example, specifying all valid columns:

[disk]
columns = ["disk", "mount", "used", "free", "total", "used%", "r/s", "w/s"]

image

Or:

[disk]
columns = ["disk", "mount", "w/s", "r/s", ]

image

Also a bunch of internal cleanups/refactoring.

Issue

If applicable, what issue does this address?

Closes: #1480

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang enabled auto-merge (squash) November 18, 2024 02:07
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 53.07263% with 84 lines in your changes missing coverage. Please review.

Project coverage is 41.97%. Comparing base (c8cba49) to head (75465ed).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/widgets/disk_table.rs 45.87% 59 Missing ⚠️
src/main.rs 0.00% 13 Missing ⚠️
src/data_conversion.rs 28.57% 10 Missing ⚠️
src/app/data_farmer.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1625       +/-   ##
===========================================
- Coverage   54.54%   41.97%   -12.58%     
===========================================
  Files         114      114               
  Lines       17621    17685       +64     
===========================================
- Hits         9612     7423     -2189     
- Misses       8009    10262     +2253     
Flag Coverage Δ
macos-12 37.41% <53.07%> (+0.15%) ⬆️
ubuntu-latest 43.75% <53.07%> (-13.25%) ⬇️
windows-2019 37.32% <53.07%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang changed the title Storage column config feature: add the ability to configure the disk widget's table columns Nov 18, 2024
@ClementTsang ClementTsang enabled auto-merge (squash) November 18, 2024 02:08
@ClementTsang ClementTsang merged commit 196d6d1 into main Nov 18, 2024
36 checks passed
@ClementTsang ClementTsang deleted the storage_column_config branch November 18, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disk columns
1 participant