v1.0

[rgarcia]

Not ready to be merged

[jonahkagan]

In the spirit of creating more controversy, I'd like to put in a vote for naming the understream object understream instead of _s. I think it's more explicit and avoids confusion with _. _s looks like it could be a typo.

[rgarcia]

Benefits of _s:

• Invokes the same muscle-memory/areas of your brain that you associate with _, so it "feels right" typing _s.each, etc.
• Easier to type

[azylman]

One thing that we lose when we have so little context like this (only the readable stream you want to apply some transformation to) is the ability to wrap all of the streams in a domain. Is there some way that we can maintain that feature here?

[rgarcia]

@azylman possibly chain() could take some configuration re: domains, but I'm also tempted to throw away the domain experiment. We can revisit when the error.coffee test is 1.0'd.

[jonahkagan]

At this point we were only using domains to catch thrown errors, right? All emitted errors were being caught via the 'error' event. What thrown errors were we worried about? If it's just errors from user-supplied functions (e.g. fn in _s.each(stream, fn)), then can we just wrap those functions with a try/catch and then emit any caught errors?

[azylman]

@jonahkagan try/catch can't catch exceptions that are thrown asynchronously. So if a user-supplied function does some asynchronous action and throws an exception there, the only way to catch it is with domains.

[jonahkagan]

Can we use a domain to wrap the function instead of a try/catch?

[azylman]

Maybe, but I'd worry that there's too much behavior around domains we still don't understand. For instance, that would require that each stream have its OWN domain. Will multiple domains running at the same time step on each other's toes? Ideally we could do something like:

d.create()
d.add stream
d.on 'error', (err) ->
  # Check if the error is the result of throwing so we don't emit errors that have already been emitted
  stream.emit 'error', err
d.exit()

But I don't know if that's going to intercept errors from other domains (which would be bad because we'd be re-emitting on the wrong stream), or if the exit is even necessary.