Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify CI failure #387

Merged
merged 1 commit into from
Sep 23, 2024
Merged

notify CI failure #387

merged 1 commit into from
Sep 23, 2024

Conversation

tnsardesai
Copy link
Contributor

Jira

https://clever.atlassian.net/browse/INFRANG-6435

Overview

PR created via Microplane

This PR enables/fixes slack notifications via Dapple bot when CI fails on master, sent to the commit author, to ensure that eng action can be taken to ensure master doesn't remain in a failed state. This prevents issues such as a subsequent deploy deploying more new code than intended because it picks up a previous failed build's code.

If you have questions, please ask here or in #oncall-infra.

Feel free to merge this PR upon reviewing or simply ignore. If it is ignored, it will be merged by infra eventually

Testing

This github action has been tested in our do-nothing repo and test details can be found in Clever/ci-scripts#140

@tnsardesai tnsardesai requested a review from a team as a code owner September 19, 2024 03:07
@tnsardesai tnsardesai self-assigned this Sep 19, 2024
@tnsardesai tnsardesai requested review from jakegut and removed request for a team September 19, 2024 03:07
Copy link
Contributor

@andruwm andruwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed automatically via cli for a microplane PR

@tnsardesai tnsardesai merged commit 467604b into master Sep 23, 2024
3 checks passed
@tnsardesai tnsardesai deleted the INFRANG-6435 branch September 23, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants