feat(logs): support duration in since parameters #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurrelhebert
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
LGTM and very helpful ;) What about ISODuration : https://en.wikipedia.org/wiki/ISO_8601#Durations? Which format of durations should we support?
This was referenced Feb 22, 2024
|
It looks like there is a lib to support ISO_DURATION: https://www.npmjs.com/package/iso8601-duration |
miton18
force-pushed
the
feat/logs-duration
branch
4 times, most recently
from
dbcbb95
to
11629e4
Compare
|
🔎 A preview has been automatically published:
This preview will be deleted once this PR is closed. |
miton18
force-pushed
the
feat/logs-duration
branch
from
11629e4
to
a223f3a
Compare
aurrelhebert
approved these changes
Mar 5, 2024
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.