fix: add an alias/name check during app create #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miton18
requested changes
Jan 19, 2024
hsablonniere
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Hey @davlgd, thank you for this. I added a few nitpicks but we tested the branch and it works great!
miton18
reviewed
Jan 19, 2024
miton18
approved these changes
Jan 19, 2024
davlgd
force-pushed
the
davlgd-alias-notwice
branch
from
e24933f
to
b5602e5
Compare
Co-Authored-By: Collignon-Ducret Rémi <miton18@users.noreply.github.com>
miton18
force-pushed
the
davlgd-alias-notwice
branch
from
b5602e5
to
9a3ea44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #656