Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(domain): introduce domain overview command #828

Merged
merged 4 commits into from
Oct 23, 2024
Merged

feat(domain): introduce domain overview command #828

merged 4 commits into from
Oct 23, 2024

Conversation

hsablonniere
Copy link
Member

@hsablonniere hsablonniere commented Oct 9, 2024 •
edited
Loading

TODO

  • rebase on master once rework is merged
  • review UX and namings
  • waiting for final short URL design
  • fix problem with filter with alias -f (check diag command too)

@hsablonniere hsablonniere added this to the 3.9.0 milestone Oct 9, 2024
@hsablonniere hsablonniere changed the title feat(domain): introduce a list command feat(domain): introduce domain overview command Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

🔎 A preview has been automatically published:

  • 🐧 linux 0391ea664535fba4a2dbf7b1ec3d082267641680d55b82f6688649a9de790de3
  • 🍏 macos 276ad7a5cc2938925207cc15fca467ed84019e2d949426f09717d28643695d55
  • 🪟 win 3759e26eb46c6211f09a49c9b604498956df90062312741ac28c78a6328dc927

This preview will be deleted once this PR is closed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

🔎 A preview has been automatically published:

  • 🐧 linux e91235e62c8ad9abc7baee43efdfd8795f00f0ccf07610a78b25576682e8270d
  • 🍏 macos 0986c42b02d66024557ac178c8629e089b91b4aa52194f58636ccec4c07fb470
  • 🪟 win e38b1a5d87098d6b30b2ba7749fdc03a623c4253fc02fbc97d6fded5ca58c89e

This preview will be deleted once this PR is closed.

@hsablonniere hsablonniere marked this pull request as ready for review October 9, 2024 11:33
@hsablonniere hsablonniere requested a review from a team as a code owner October 9, 2024 11:33
@hsablonniere hsablonniere force-pushed the domain-list branch 2 times, most recently from d496418 to c9f04fe Compare October 9, 2024 13:03
@hsablonniere hsablonniere force-pushed the domain-list branch 2 times, most recently from 131ccce to cb9c386 Compare October 16, 2024 17:53
florian-sanders-cc
florian-sanders-cc requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@florian-sanders-cc florian-sanders-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few suggestions and there might be one oversight about the display format in human mode.

About the naming, I still wonder if domain inventory could be a better match 🤔

Thanks for handling all of this, so glad we are getting this command!

src/commands/domain.js Outdated Show resolved Hide resolved
src/commands/domain.js Outdated Show resolved Hide resolved
src/commands/domain.js Outdated Show resolved Hide resolved
@pdesoyres-cc pdesoyres-cc self-requested a review October 17, 2024 07:52
pdesoyres-cc
pdesoyres-cc requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. I've got some minor nitpicks that you may want to consider.

src/commands/domain.js Outdated Show resolved Hide resolved
src/commands/domain.js Outdated Show resolved Hide resolved
src/commands/domain.js Outdated Show resolved Hide resolved
src/commands/domain.js Outdated Show resolved Hide resolved
@hsablonniere hsablonniere force-pushed the domain-list branch 2 times, most recently from 303d3ae to f8424c7 Compare October 21, 2024 13:01
@hsablonniere hsablonniere force-pushed the domain-list branch 3 times, most recently from aa0f97e to 00ff392 Compare October 22, 2024 14:30
@hsablonniere hsablonniere merged commit 7107ee4 into master Oct 23, 2024
5 checks passed
@hsablonniere hsablonniere deleted the domain-list branch October 23, 2024 10:24
@github-actions GitHub Actions
Copy link

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davlgd davlgd davlgd left review comments

@florian-sanders-cc florian-sanders-cc Awaiting requested review from florian-sanders-cc

@pdesoyres-cc pdesoyres-cc Awaiting requested review from pdesoyres-cc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hsablonniere @davlgd @florian-sanders-cc @pdesoyres-cc