feat(addon): add URL to use/manage add-on at creation #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔎 A preview has been automatically published:
This preview will be deleted once this PR is closed. |
- When an add-on is created we get its env vars and show them in JSON format - For human format we show interface/console URL in some cases
hsablonniere
force-pushed
the
davlgd-addon-url-at-creation
branch
from
a1ab311
to
36226c5
Compare
hsablonniere
approved these changes
Oct 16, 2024
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For add-ons with a public management URL, we tell the user what the URL is at creation, to ease onboarding. For that I added add-on env to returned object after creation (we'll move this to API side in a future iteration).
I've only done this for KC, Matomo, Metabase for now, but we'll can go further for other add-ons too. This commit was based on refactor branch