Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(domain): add missing spacing within diag report #846

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(domain): add missing spacing within diag report #846

merged 1 commit into from
Nov 19, 2024

Conversation

florian-sanders-cc
Copy link
Contributor

What does this PR do?

  • Adds a missing space between the record and the text "from (...)" when there are invalid A records coming from a CNAME

In prod:
image

With the fix:
image

@florian-sanders-cc florian-sanders-cc requested a review from a team as a code owner November 5, 2024 11:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

🔎 A preview has been automatically published:

  • 🐧 linux fa5c75dc7b941e7677ea12c6ef2735db9d31fd51ec6a2cd6afadd7c77724ab0f
  • 🍏 macos 823f334dddde70f9404a07a2d27f8e9dcdada60c34e79b943675f7d89135c5d2
  • 🪟 win 806eb26eb165b8c6aaecede2b9c8931ba8ef12b414ec8d0da5ebbcc6549fa08d

This preview will be deleted once this PR is closed.

hsablonniere
hsablonniere approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@hsablonniere hsablonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on built version! 👍

@hsablonniere hsablonniere merged commit 93e5ca3 into master Nov 19, 2024
5 checks passed
@hsablonniere hsablonniere deleted the domains/fix-diag-typo branch November 19, 2024 16:00
@github-actions GitHub Actions
Copy link

🔎 The preview has been automatically deleted.

@hsablonniere hsablonniere added this to the 3.9.1 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsablonniere hsablonniere hsablonniere approved these changes

Assignees

@hsablonniere hsablonniere

Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-sanders-cc @hsablonniere