skip conversion of percentiles, not compatible with prometheus #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft of histogram conversion
Keksoj
force-pushed
the
suppress-conversion-of-percentiles
branch
2 times, most recently
from
94b19a7 to
632ba39
Compare
FlorentinDUBOIS
requested changes
Oct 20, 2023
debug statements
Keksoj
force-pushed
the
suppress-conversion-of-percentiles
branch
from
632ba39 to
e7a1f2b
Compare
FlorentinDUBOIS
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
producing "percentiles" metrics was a mistake from the beginning!
We will have to wait for Sōzu to produce histogram metrics, those are convertible to prometheus