feat: metabase #94
Merged
feat: metabase #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCrabe
force-pushed
the
feat/metabase
branch
3 times, most recently
from
e076a7b to
f621b4c
Compare
miton18
requested changes
Dec 17, 2024
pkg/resources/metabase/crud.go
Outdated
Comment on lines
148
to
150
| if resp.Diagnostics.HasError() { | ||
| return | ||
| } |
| return nil | ||
| }, | ||
| Steps: []resource.TestStep{ | ||
| // create a database instance on first step |
There was a problem hiding this comment.
Suggested change
| // create a database instance on first step | |
| // create a Metabase instance on first step |
| ResourceName: rName, | ||
| PreConfig: func() { | ||
| // delete the database using an api call | ||
| tmp.DeleteAddon(context.Background(), cc, org, rName) |
pkg/resources/metabase/schema.go
Outdated
| Attributes: attributes.WithAddonCommons(map[string]schema.Attribute{ | ||
| // customer provided | ||
| // TODO: Markdown description | ||
| "host": schema.StringAttribute{Computed: true, MarkdownDescription: "Database host, used to connect to"}, |
There was a problem hiding this comment.
Suggested change
| "host": schema.StringAttribute{Computed: true, MarkdownDescription: "Database host, used to connect to"}, | |
| "host": schema.StringAttribute{Computed: true, MarkdownDescription: "Metabase host, used to connect to"}, |
TheCrabe
force-pushed
the
feat/metabase
branch
from
f621b4c to
6864078
Compare
fix: Read for tests fix: suggested chances
TheCrabe
force-pushed
the
feat/metabase
branch
from
6864078 to
43ec557
Compare
miton18
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Read for tests
Closes #88