src/do_turn.cpp:411: game:monmove: foo can't move to its location! (72:67:0), bar spam and other funky stuff when hallucinating

[l29ah]

Describe the bug

02:39:35.128 ERROR GAME : src/do_turn.cpp:411: game:monmove: improvised MP5 turret can't move to its location!  (69:58:0), log wall
02:39:38.294 ERROR GAME : src/do_turn.cpp:411: game:monmove: dermatik can't move to its location!  (68:59:0), floor
02:39:59.917 ERROR GAME : src/do_turn.cpp:411: game:monmove: decayed pouncer can't move to its location!  (66:63:0), log wall
02:40:00.935 ERROR GAME : src/do_turn.cpp:411: game:monmove: bulldog puppy can't move to its location!  (81:59:0), log wall
02:40:01.127 ERROR GAME : src/do_turn.cpp:411: game:monmove: upcycled turret can't move to its location!  (76:67:0), log wall
02:40:01.170 ERROR GAME : src/do_turn.cpp:411: game:monmove: brown chick can't move to its location!  (76:63:0), log wall
02:40:01.184 ERROR GAME : src/do_turn.cpp:411: game:monmove: cattle dog can't move to its location!  (65:61:0), log wall
02:40:08.395 ERROR GAME : src/do_turn.cpp:411: game:monmove: pupating zombie can't move to its location!  (65:66:0), log wall
02:40:26.469 ERROR GAME : src/do_turn.cpp:411: game:monmove: steelhead trout can't move to its location!  (81:66:0), log wall
02:40:26.551 ERROR GAME : src/do_turn.cpp:411: game:monmove: necrowolf spider can't move to its location!  (66:59:0), floor
02:40:26.572 ERROR GAME : src/do_turn.cpp:411: game:monmove: muskellunge can't move to its location!  (66:60:0), floor
02:40:26.588 ERROR GAME : src/do_turn.cpp:411: game:monmove: praying mantis can't move to its location!  (65:63:0), log wall
02:40:26.625 ERROR GAME : src/do_turn.cpp:411: game:monmove: jumping spider can't move to its location!  (67:64:0), floor
02:40:26.647 ERROR GAME : src/do_turn.cpp:411: game:monmove: redear sunfish can't move to its location!  (65:63:0), log wall
02:40:26.869 ERROR GAME : src/do_turn.cpp:411: game:monmove: caustic soldier zombie can't move to its location!  (70:68:0), window with closed curtains
02:40:26.991 ERROR GAME : src/do_turn.cpp:411: game:monmove: ravenous reenactor can't move to its location!  (73:59:0), log wall
02:40:27.048 ERROR GAME : src/do_turn.cpp:411: game:monmove: tadpole can't move to its location!  (80:62:0), log wall
02:40:27.177 ERROR GAME : src/do_turn.cpp:411: game:monmove: swimmer zombie can't move to its location!  (80:61:0), floor
02:40:27.286 ERROR GAME : src/do_turn.cpp:411: game:monmove: hive hulk can't move to its location!  (77:62:0), log wall
02:40:27.295 ERROR GAME : src/do_turn.cpp:411: game:monmove: zombear can't move to its location!  (68:60:0), floor
02:40:27.468 ERROR GAME : src/do_turn.cpp:411: game:monmove: broken cyborg can't move to its location!  (75:63:0), chipped log wall
02:40:27.487 ERROR GAME : src/do_turn.cpp:411: game:monmove: Maine coon cat can't move to its location!  (72:67:0), chipped log wall
02:40:27.554 INFO : npc::set_omt_destination - new goal for NPC [Fidela Silva] with [need_safety] is [2silos] in (21,264,0).
02:40:27.561 ERROR GAME : src/do_turn.cpp:411: game:monmove: rock bass can't move to its location!  (76:64:0), log wall
02:40:27.584 ERROR GAME : src/do_turn.cpp:411: game:monmove: unstable flesh-raptor can't move to its location!  (76:67:0), log wall
02:40:27.724 ERROR GAME : src/do_turn.cpp:411: game:monmove: giant bee can't move to its location!  (70:57:0), log wall
02:40:27.802 INFO : npc::set_omt_destination - new goal for NPC [Sima Noriega] with [need_safety] is [house_farm] in (21,262,0).
02:40:27.815 ERROR GAME : src/do_turn.cpp:411: game:monmove: leech stalk can't move to its location!  (72:67:0), chipped log wall
02:40:27.915 ERROR GAME : src/do_turn.cpp:411: game:monmove: German Shepherd puppy can't move to its location!  (77:67:0), log wall
02:40:27.956 ERROR GAME : src/do_turn.cpp:411: game:monmove: deathtrap spider can't move to its location!  (81:67:0), log wall
02:40:27.984 ERROR GAME : src/do_turn.cpp:411: game:monmove: rust plated zombie can't move to its location!  (71:67:0), log wall
02:40:28.018 ERROR GAME : src/do_turn.cpp:411: game:monmove: giant cockroach can't move to its location!  (67:61:0), log wall
02:40:28.056 ERROR GAME : src/do_turn.cpp:411: game:monmove: alpha bee can't move to its location!  (72:57:0), log wall
02:40:28.179 ERROR GAME : src/do_turn.cpp:411: game:monmove: hound of tindalos can't move to its location!  (76:65:0), log wall
02:40:28.276 ERROR GAME : src/do_turn.cpp:411: game:monmove: web spinning spider can't move to its location!  (69:60:0), log wall
02:40:28.339 ERROR GAME : src/do_turn.cpp:411: game:monmove: piglet can't move to its location!  (65:57:0), log wall
02:40:28.377 ERROR GAME : src/do_turn.cpp:411: game:monmove: twitching spider can't move to its location!  (71:63:0), log wall

et cetera

Steps to reproduce

Load the game and wait.

Expected behavior

No errors.

Screenshots

No response

Versions and configuration

• OS: Linux
  • OS Version:
• Game Version: 0.F-4257-gc232b413eb-dirty [64-bit]
• Graphics Version: Curses
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions],
  No Rail Stations [No_Rail_Stations]
  ]

Additional context

2021.12.05-2.zip

[l29ah]

Also a hallucinated pupating brute have pushed my car when i was sitting inside!

[l29ah]

Got myself a loaded shotgun and a leather belt from a hallucinated NPC.
Befriended another hallucinated NPC and now he occupies the seat of my real friend NPC in my van :(

[l29ah]

Z-Level view violation: the zeindeer tried to attack the wasp larva.

[l29ah]

Ordered the allied NPC i hallucinated to drop stuff he isn't using, and got lots of nice stuff.

[l29ah]

Nice, i can even strip every possession of him if i examine -> trade.

[l29ah]

Interestingly my real allies attack the hallucinated NPC too if i piss him off.

[wapcaplet]

Also a hallucinated pupating brute have pushed my car when i was sitting inside!

This is similar to #52808

Similar issues #53503 and #53510 for hallucinated NPCs

[hexagonrecursion]

There are several hallucination related bugs mixed here. I can split them by verifying and reposting every bug individually. @wapcaplet, should I?

[wapcaplet]

There are several hallucination related bugs mixed here. I can split them by verifying and reposting every bug individually. @wapcaplet, should I?

@hexagonrecursion Yes, that would be helpful for tracking, thanks!

[Michael1993]

A simple solution (I think) to the original issue would be to replace (on line 410)

if( !critter.is_dead() && m.impassable( critter.pos() ) && !critter.can_move_to( critter.pos() ) )

with

if( !critter.is_dead() && !critter.is_hallucination() && m.impassable( critter.pos() ) && !critter.can_move_to( critter.pos() ) )

Quite possibly this just "masks" the issue (ignore hallucinations being unable to move), but I'm not really sure how a real fix would look like. (I think this solution would/could lead to hallucinating zombies into solid rock (?), lol. "They are in the walls!")

[hexagonrecursion]

Let's keep this thread focused on one bug - the "can't move to its location" assertion - this helps us coordinate troubleshooting. I have opened issues for other bugs reported here. Thank you.

I can confirm this. The game does not show the debug assertion dialogue, but it does freeze for a bit (trace generation usually takes several seconds) and the following is printed to the debug log:

    ./with-debug-symbols-cataclysm-tiles(debug_write_backtrace(std::ostream&)+0x23) [0x293e8d3]
    ./with-debug-symbols-cataclysm-tiles(DebugLog(DebugLevel, DebugClass)+0x166) [0x293e0a6]
    ./with-debug-symbols-cataclysm-tiles() [0x29d1dc7]
    ./with-debug-symbols-cataclysm-tiles(do_turn()+0x8e0) [0x29d1210]
    ./with-debug-symbols-cataclysm-tiles(main+0x515) [0x2f46305]
    /lib64/libc.so.6(__libc_start_main+0xd5) [0x70cfb4586b75]
    ./with-debug-symbols-cataclysm-tiles(_start+0x2e) [0x247d7ce]

    Attempting to repeat stack trace using debug symbols…
    debug_write_backtrace(std::ostream&)
    …/src/debug.cpp:1104
    DebugLog(DebugLevel, DebugClass)
    …/src/debug.cpp:1331
    (anonymous namespace)::monmove()
    …/src/do_turn.cpp:411
    do_turn()
    …/src/do_turn.cpp:779
    main
    …/src/main.cpp:711
    __libc_start_main
    ??:?
    _start
    ??:?
Backtrace emission took 15 seconds.
(continued from above) ERROR : src/do_turn.cpp:411: game:monmove: thing can't move to its location!  (65:72:0), log wall

• OS: Linux
  • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 34 (Thirty Four); Release: 34; Codename: ThirtyFour;
• Game Version: 0.F-4523-g00a57e1f7d [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions]
  ]