chore(SDK-3553) Additional methods for Variables and fix iOS #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PJClevertap
commented
Dec 25, 2023
PJClevertap
commented
- Added event OnOneTimeVariablesChanged
- Added StringValue on Var
- Added SyncVariables(bool isProduction) for iOS (android will fallback to SyncVariables())
- Fix JSON validation issue in getVariableValue on iOS
- Simplified getVariableValue on Android
- Added event OnOneTimeVariablesChanged - Added StringValue on Var - Added SyncVariables(bool isProduction) for iOS (android will fallback to SyncVariables()) - Fix JSON validation issue in getVariableValue on iOS - Simplified getVariableValue on Android
milos-clevertap
approved these changes
Dec 25, 2023
PJClevertap
added a commit
that referenced
this pull request
Dec 27, 2023
commit dc15ae6 Author: PJClevertap <144137874+PJClevertap@users.noreply.github.com> Date: Wed Dec 27 04:49:39 2023 +0100 chore(SDK-3553) Additional methods for Variables and fix iOS (#62) - Added event OnOneTimeVariablesChanged - Added StringValue on Var - Added SyncVariables(bool isProduction) for iOS (android will fallback to SyncVariables()) - Fix JSON validation issue in getVariableValue on iOS - Simplified getVariableValue on Android commit a00b3e2 Author: PJClevertap <144137874+PJClevertap@users.noreply.github.com> Date: Fri Dec 22 12:07:30 2023 +0100 chore(SDK-3548) - fix string variables (#61) - Remove "" from variable if variable is of kind string commit 0341e53 Merge: 018ca20 9f4fb98 Author: milos-clevertap <144123971+milos-clevertap@users.noreply.github.com> Date: Wed Dec 20 17:30:40 2023 +0100 Merge pull request #60 from CleverTap/mj/bugfix/fixing-variable-changed Fixing sending of variables back to Unity commit 9f4fb98 Author: Milos Jakovljevic <milos1290@gmail.com> Date: Wed Dec 20 14:34:37 2023 +0100 Fixing sending of variables back to Unity
nzagorchev
added a commit
that referenced
this pull request
Jan 15, 2024
* GetCleverTapID return value * [SDK-3121] Init CleverTapUnityManager on App Launch (#46) * initial commit to handle notification clicked dor Android 12 * revert stray change * update to 2.4.1 aar * update to android 5.2.0 and rebuild package * fix typo in CleverTapBinding * update package and changelog * Use CT Android SDK 5.1.0 (#47) * Use CT Android SDK 5.1.0 * Update version (#48) * Feature/sdk 3235/split bindings and clevertap (#50) * chore(SDK-3235) - Split bindings and clevertap Added Default abstract CleverTapPlatformBinding class that will serve as interface and base implementation of bindings Refcator bindings to split them based on platform Added BindingFactory that will instantiate appropriate instance based on platform build Added static clevertap class as entrypoint Added ClevetapCallback for delegation * chore(SDK-3235) - Split bindings and clevertap Additional refactoring Restructure CleverTapUnity (SDK) Improved CleverTap callback event handlers CleverTapUnity (SDK) changed to a more generic approach Added initialization of game object in memory and attached platform-specific callback handler * chore(SDK-3235) - Split bindings and clevertap Fixed minor issues * chore(SDK-3235) - Split bindings and clevertap Adapted code formatting following confluence c# guidelines Included directives for each platform Fixed unity warning with instantiation of gameObject for CleverTapCallbackHanlder Code improvements, simplification and refactoring * chore(SDK-3235) - Split bindings and clevertap Fixed typo in BindingFactory * chore(SDK-3235) - Split bindings and clevertap Added name to callback GameObject * chore(SDK-3235) - Split bindings and clevertap Integrated new arhitecture in existing bindings, callbacks and CleverTapUnity Refactor and fixed some issues * chore(SDK-3235) - Split bindings and clevertap Added obsolete to existing clevertap methods with message to start using new clevertap arhitecture Added example with new clevertap arhitecture * chore(SDK-3235) - Split bindings and clevertap Removed Obsolete from CleverTapUnity to show warning when using CleverTapBinding * chore(SDK-3235) - Split bindings and clevertap Changed namespace from CleverTapUnitySDK to CleverTap in new arhitecture classes Change access modifier on most classes from public to internal in new arhitecture classes Added CleverTapVersion, CleverTapLogger and CleverTapAndroidJNI classes Code refactoring and improvements * Merge Profile APIs to develop (#52) * Release v2.4.1 (#49) * GetCleverTapID return value * [SDK-3121] Init CleverTapUnityManager on App Launch (#46) * initial commit to handle notification clicked for Android 12 * update to 2.4.1 aar * update package and changelog * Use CT Android SDK 5.1.0 * Update version (#48) --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> * Profile APIs support for multiple data types (#51) * overload profile apis to support object * Update version * Update package --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> * Feature/sdk 3323/variables bindings (#54) * chore(SDK-3323) - Variables bindings Added implementation of Var for iOS and Android Added implementation of platform variables for iOS and Android Added implementation of variables callback handler Added variable factory as shared instance Added variables methods and callbacks in CleverTap.cs Refactoring, improvements and code optimization * Adding wrapper for Vars on Android * chore(SDK-3323) - Variables bindings Fixed some issues Refactoring and code improvements * chore(SDK-3323) - Variables bindings Fixed issue in CleverTapAndroidJNI * chore(SDK-3323) - Variables bindings Update version of clevertap-android-sdk to 5.2.1 Update clevertapsdk-unity Fixed issue with android GetCleverTapID binding Fixed issue with callbacks if there are no subscribers * chore(SDK-3323) - Variables bindings Minor fix * Squashed commit of the following: commit c2e9a7d Author: Nikola Zagorchev <nikola.zagorchev@gmail.com> Date: Fri Oct 27 10:39:59 2023 +0300 Merge Profile APIs to develop (#52) * Release v2.4.1 (#49) * GetCleverTapID return value * [SDK-3121] Init CleverTapUnityManager on App Launch (#46) * initial commit to handle notification clicked for Android 12 * update to 2.4.1 aar * update package and changelog * Use CT Android SDK 5.1.0 * Update version (#48) --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> * Profile APIs support for multiple data types (#51) * overload profile apis to support object * Update version * Update package --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> * chore(SDK-3323) - Variables bindings Resolve confits with develop * Squashed commit of the following: commit c2e9a7d Author: Nikola Zagorchev <nikola.zagorchev@gmail.com> Date: Fri Oct 27 10:39:59 2023 +0300 Merge Profile APIs to develop (#52) * Release v2.4.1 (#49) * GetCleverTapID return value * [SDK-3121] Init CleverTapUnityManager on App Launch (#46) * initial commit to handle notification clicked for Android 12 * update to 2.4.1 aar * update package and changelog * Use CT Android SDK 5.1.0 * Update version (#48) --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> * Profile APIs support for multiple data types (#51) * overload profile apis to support object * Update version * Update package --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> * Squashed commit of the following: commit c2e9a7d Author: Nikola Zagorchev <nikola.zagorchev@gmail.com> Date: Fri Oct 27 10:39:59 2023 +0300 Merge Profile APIs to develop (#52) * Release v2.4.1 (#49) * GetCleverTapID return value * [SDK-3121] Init CleverTapUnityManager on App Launch (#46) * initial commit to handle notification clicked for Android 12 * update to 2.4.1 aar * update package and changelog * Use CT Android SDK 5.1.0 * Update version (#48) --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> * Profile APIs support for multiple data types (#51) * overload profile apis to support object * Update version * Update package --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> * chore(SDK-3323) - Variables bindings Remove old version of clevertapsdk-unity * Unity Package support (#53) * Unity Package support * Updating unity package * Changes * fixing iOS variables * fixing iOS build system * Android and iOS changes * Unity sdk changes * Fixed issue with GetVariable * changes * adding CTTester used for exporting the project * adding CTIntegrationTests for development and testing * adding build script that exports unity package * adding missing variable bindings * removing unused files --------- Co-authored-by: Milos Jakovljevic <milos1290@gmail.com> Co-authored-by: PJClevertap <peter.janjic@clevertap.com> * chore(SDK-3323) - Variables bindings Fixed path in CTIntegrationTests/Packages/: manifest.json packages-lock.json * chore(SDK-3323) - Variables bindings Added CleverTapExample * changes * adding androidlib * renaming export project * rebuilding new package * Fixing export script to include android-lib * chore(SDK-3498) Variables bindings and dates tests (#56) Added tests for variables Added tests for dates support --------- Co-authored-by: Milos Jakovljevic <milos1290@gmail.com> Co-authored-by: milos-clevertap <144123971+milos-clevertap@users.noreply.github.com> * Fixing wrong params sent to iOS SDK * Fixing sending of variables back to Unity * chore(SDK-3548) - fix string variables (#61) - Remove "" from variable if variable is of kind string * chore(SDK-3553) Additional methods for Variables and fix iOS (#62) - Added event OnOneTimeVariablesChanged - Added StringValue on Var - Added SyncVariables(bool isProduction) for iOS (android will fallback to SyncVariables()) - Fix JSON validation issue in getVariableValue on iOS - Simplified getVariableValue on Android * Feature/sdk 3554 in apps (#63) * chore(SDK-3554) - Wrappers InApps implementation -Added InApps implementation on Android -Added InApps implementation on iOS * chore(SDK-3554) - Unity InApps implementation - Added InAppsFactory - Added CleverTapPlatformInApps - Added CleverTapPlatformInApps for Android and iOS - Added CleverTapInAppsFetched callback - Added mising unity native method for variable * Fix iOS conflicting type issue for syncVariables * Add clearInAppResources method * resolved merged conflicts * added missing bool in the call * compilation error fixes --------- Co-authored-by: Nikola Zagorchev <nikola.zagorchev@gmail.com> Co-authored-by: Alok Kumar <alok@clevertap.com> * iOS Post Build processor and settings window (#64) * Add Post Build processor for iOS. Add settings window for the config. * Add to namespace and format * Prepare 3.0.0 release (#65) * Prepare 3.0.0 release * Update README.md * Update android-wrapper build.gradle * Update package --------- Co-authored-by: Peter Wilkniss <peter@clevertap.com> Co-authored-by: PJClevertap <144137874+PJClevertap@users.noreply.github.com> Co-authored-by: Milos Jakovljevic <milos1290@gmail.com> Co-authored-by: milos-clevertap <144123971+milos-clevertap@users.noreply.github.com> Co-authored-by: Alok Kumar <alok@clevertap.com>
nzagorchev
pushed a commit
that referenced
this pull request
Apr 24, 2024
- Added event OnOneTimeVariablesChanged - Added StringValue on Var - Added SyncVariables(bool isProduction) for iOS (android will fallback to SyncVariables()) - Fix JSON validation issue in getVariableValue on iOS - Simplified getVariableValue on Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.