Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3326] Fixed White Background issue in Web Popup #305

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

singhkunal2050
Copy link
Contributor

@singhkunal2050 singhkunal2050 commented Nov 13, 2024

Changes

WEB-3326 The customer website (viu.com) which was having web popup with white background instead of a transparent overlay.

After investigation we found it was due to the color-scheme:dark property on the top document. As a fix we have reset the color-scheme property in the web-popup iframe which fixes the issue

Refer Screenshot

image

Changes to Public Facing API if any

No Changes

How Has This Been Tested?

  • Tested the Web Popup on the client website by overriding the style of the iframe as shown in the screenshot
  • Toggled the system theme to dark and light to verify it across color themes

Checklist

  • Code compiles without errors
  • Version Bump added to package.json & CHANGELOG.md
  • All tests pass
  • Build process is successful
  • Documentation has been updated (if needed)

@singhkunal2050 singhkunal2050 merged commit 3dd692c into develop Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants