Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3373] Fixed Web Inbox MarkAsRead API for Custom Web Inbox Implementation #324

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

singhkunal2050
Copy link
Contributor

Changes

SUC-126458 , WEB-3373 The customer website was facing issues where they had implemented a custom Web Inbox and the markReadInboxMessage API was not working as expected

After investigation we found it was due to the a bug in the markReadInboxMessage API, After further investigation we found issues within the other Custom Web Inbox APIs too which included.

clevertap.getInboxMessageUnreadCount() // ❌ 
clevertap.markReadAllInboxMessage()  // ❌ 
clevertap.getUnreadInboxMessages()  // ❌ 
clevertap.markReadInboxMessage('1730711694_1734502972434') // ❌ 
clevertap.markReadInboxMessagesForIds() //❌ 

For a long term refactor and cleanup this doc was created to analyze the problems with the current state of web inbox https://wizrocket.atlassian.net/wiki/spaces/EN/pages/5135106074/Custom+Web+Inbox+Bugs+Issues

Changes to Public Facing API if any

Fixed the following APIS

  • clevertap.getInboxMessageUnreadCount()
  • clevertap.markReadAllInboxMessage()
  • clevertap.getUnreadInboxMessages()
  • clevertap.markReadInboxMessage()
  • clevertap.markReadInboxMessagesForIds()

How Has This Been Tested?

  • Overrided the build sdk in the demo website https://clevertap-sdk-test.netlify.app/custominbox?region=eu1&accountId=ZWW-WWW-WWRZ&token=000-001 to test custom Web Inbox Implementation
  • Created a campaign and tested web inbox messages getting sent for Added to Cart Event
  • Verified getInboxMessageUnreadCount, markReadAllInboxMessage, getUnreadInboxMessages, markReadInboxMessage, markReadInboxMessagesForIds
  • Verified the Custom Inbox APIs with the DOM Node added and Native Inbox open too and no impact or conflict was found

Checklist

  • Code compiles without errors
  • Version Bump added to package.json & CHANGELOG.md
  • All tests pass
  • Build process is successful
  • Documentation has been updated (if needed)

@singhkunal2050 singhkunal2050 merged commit 09391fc into master Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants