Feat: Method Scan, Value fo fixedpoint #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Failed to complete Code Analysis & Testing (go version go1.21.13 linux/amd64)💡 Please fix the errors before merging this pull request. |
bombnp
approved these changes
Dec 20, 2024
| } | ||
|
|
||
| switch v := value.(type) { | ||
| case decimal.Decimal: |
There was a problem hiding this comment.
Add case decimal.NullDecimal, because why not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scan
Why not using f.d.Scan directly?
fixedpoint.Fixpointso when the driver see our custom type it pass thedecimal.Decimaltype and if we just callf.d.Scaninf.d.Scanit only handle type offloat32,float64,int64,uint64,string (default case)so it fall to default case that is astringand then it will fall to another default case inunquoteIfQuotefunction that checking the type ofstringand[]byteonly, so it fall to another default case that return an error