Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove manifest, fix mcmc performance #188

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Oct 1, 2022

Purpose

Removes manifest from project. Doing so caused performance hit, changed offending lines to regain performance.

Content

@odunbar odunbar force-pushed the orad/mcmc-perf-upate-manifest branch from b0ab975 to 5ef6f06 Compare October 1, 2022 21:54
@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Base: 88.71% // Head: 88.65% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (805e8d7) compared to base (374ded6).
Patch coverage: 71.42% of modified lines in pull request are covered.

❗ Current head 805e8d7 differs from pull request most recent head 9dd92cb. Consider uploading reports for the commit 9dd92cb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   88.71%   88.65%   -0.06%     
==========================================
  Files           4        4              
  Lines         381      388       +7     
==========================================
+ Hits          338      344       +6     
- Misses         43       44       +1     
Impacted Files Coverage Δ
src/MarkovChainMonteCarlo.jl 79.85% <71.42%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

bors bot added a commit that referenced this pull request Oct 1, 2022
188: remove manifest, fix mcmc performance r=odunbar a=odunbar

## Purpose 
Removes manifest from project. Doing so caused performance hit, changed offending lines to regain performance.

## Content
- Fixes #184 
- Fixes #182 
- soft-fix for #169
- updates EKP compat to 0.13

Co-authored-by: odunbar <odunbar@caltech.edu>
remove repo manifest

format

fixed stepsize bug
@odunbar odunbar force-pushed the orad/mcmc-perf-upate-manifest branch from 805e8d7 to 9dd92cb Compare October 1, 2022 23:08
@odunbar
Copy link
Collaborator Author

odunbar commented Oct 1, 2022

bors r+

@CliMA CliMA deleted a comment from bors bot Oct 1, 2022
@bors
Copy link
Contributor

bors bot commented Oct 1, 2022

@bors bors bot merged commit 8d87f44 into master Oct 1, 2022
@bors bors bot deleted the orad/mcmc-perf-upate-manifest branch October 1, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance Hit for MCMC on updating Manifest? stepsize bug in MCMC
1 participant