Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orad/remove gp #205

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Orad/remove gp #205

merged 5 commits into from
Jan 30, 2023

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jan 26, 2023

Purpose

Closes #204 and updates the Lorenz example to be compatible with the version in EKP v0.14

Content

  • Updated the example interface
  • Split Lorenz_example.jl into model files (GModel.jl, GModel_common.jl) and split CES into calibrate.jl calibration file, and emulate_sample.jl.

  • I have read and checked the items on the review checklist.

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 88.65% // Head: 88.65% // No change to project coverage 👍

Coverage data is based on head (d94041e) compared to base (b8f0e96).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files           4        4           
  Lines         388      388           
=======================================
  Hits          344      344           
  Misses         44       44           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odunbar
Copy link
Collaborator Author

odunbar commented Jan 30, 2023

bors try

bors bot added a commit that referenced this pull request Jan 30, 2023
@bors
Copy link
Contributor

bors bot commented Jan 30, 2023

try

Build failed:

@odunbar
Copy link
Collaborator Author

odunbar commented Jan 30, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 30, 2023

Build succeeded:

@bors bors bot merged commit 1d46a06 into main Jan 30, 2023
@bors bors bot deleted the orad/remove-gp branch January 30, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in examples from GP.mcmc
1 participant