Compatibility with new EKP, version and updated Lorenz example #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odunbar
changed the title
This was referenced Jun 13, 2023
add MT option to predict, and add schedulers in optimizer options, as well as early termination bugfix get_logpdf -> logpdf add scaling param for default prior remove unused function call allow scaling of prior New Lorenz example setup, compat with new timestepping learning compat with new scaling inc all cases aspect ratio and printing scalings for decent recovery julia format format compat for ProgressBars and StableRNGs missed format typo another optimizer key check tests pass resolve format bug
|
bors try |
|
bors try |
tryAlready running a review |
tryBuild failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 13, 2023
218: Compatibility with new EKP, version and updated Lorenz example r=odunbar a=odunbar <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> ## Content <!--- specific tasks that are currently complete - Solution implemented --> - `get_logpdf` -> `logpdf` so that MCMC tests pass - updated the EKP Project toml. Also add compats for ProgressBars, StableRNGs - added option to set `"scheduler" => XYZ` in `optimizer_options` for RF emulators - removed Lorenz bugs in observational noise - added a scaling tuner for easily expanding/narrowing priors in RF (currently one for input and one for output space) - added some diagnostic information to compare the prior support and optimal parameters to aid with the tuning. <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [ ] I have read and checked the items on the review checklist. Co-authored-by: odunbar <odunbar@caltech.edu>
Unfortunately this is a known, and apparently intermittent error in ProgressBars. Will push bors a couple of times |
|
Build failed:
|
|
bors try |
|
Bugfix seems to work, though will throw overwrite warnings on compile |
|
bors r+ |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Content
get_logpdf->logpdfso that MCMC tests pass"scheduler" => XYZinoptimizer_optionsfor RF emulators