Remove GModel dependence on Cloudy #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 17, 2020
35: Remove GModel dependence on Cloudy r=charleskawczynski a=charleskawczynski This removes the dependence of GModel on Cloudy, but there is still a need for a `Pkg.build()` in GModel, which would be nice to remove: ``` # TODO: Remove build (which currently prevents segfault): using Pkg; Pkg.build() ``` Without this `Pkg.build()`, the code segfaults in the GPR test. I'll open an issue regarding this. The good thing here is that now CalibrateEmulateSample.jl has no knowledge of Cloudy (except for in the Cloudy example). Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 61.12% 61.12%
=======================================
Files 12 12
Lines 481 481
=======================================
Hits 294 294
Misses 187 187
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependence of GModel on Cloudy, but there is still a need for a
Pkg.build()in GModel, which would be nice to remove:Without this
Pkg.build(), the code segfaults in the GPR test. I'll open an issue regarding this.The good thing here is that now CalibrateEmulateSample.jl has no knowledge of Cloudy (except for in the Cloudy example).