Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cloudy test and Cloudy notebook #44

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

bielim
Copy link
Contributor

@bielim bielim commented Mar 3, 2020

Update Cloudy test to use lognormal priors.
Update Cloudy notebook such that it can be run with the current version of the CES code. @charleskawczynski: I know that you hate that notebook (or notebooks in general), but until we decide to delete it I'll keep updating it from time to time :-)

@bielim bielim requested a review from charleskawczynski March 3, 2020 22:07
@bielim bielim self-assigned this Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #44 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   59.17%   58.64%   -0.54%     
==========================================
  Files          12       12              
  Lines         485      486       +1     
==========================================
- Hits          287      285       -2     
- Misses        198      201       +3
Impacted Files Coverage Δ
src/Utilities.jl 25% <0%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d3feb...cd122bd. Read the comment docs.

@charleskawczynski
Copy link
Member

@charleskawczynski: I know that you hate that notebook (or notebooks in general), but until we decide to delete it I'll keep updating it from time to time :-)

I'm fine with keeping the notebook around if you find that it has value. It may be more efficient to use Literate to generate notebooks from the existing Julia script though, so that you don't need to maintain duplicate versions.

@bielim
Copy link
Contributor Author

bielim commented Mar 4, 2020

I will look into that, thanks!

@bielim
Copy link
Contributor Author

bielim commented Mar 4, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 4, 2020

Build succeeded

@bors bors bot merged commit 9c66526 into master Mar 4, 2020
@bors bors bot deleted the mb/update_Cloudy_test_and_notebook branch March 4, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants