-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up CalibrateEmulateSample #67
Conversation
@dburov190: I believe you are the creator of |
@charleskawczynski: One issue I see with the current structure (separate |
…ject.toml, this removed the chaff from the Manifest
tryBuild succeeded: |
bors r+ |
Build succeeded: |
35 -> 13 minutes, nice! |
@bielim looks like you figured out how to avoid this auto-project update problem. Please reach out if this is not the case! |
This PR is a major clean-up (goal: code hygiene and reduction of the insanely long precompile times, i.e., addressing #65) -- the following changes were made:
(1) Deleted the modules
EKS.jl
,GPR.jl
,Histograms.jl
,problems.jl
, andspaces.jl
. These modules are not functional and not being developed anymore.(2) Deleted
test/EKS
,test/Histograms
,test/GPR
,test/L96m
, as well asexamples/GPR
andexamples/L96
, because they are based on non-functional modules or (in the case ofL96
) because they don't seem to demonstrate any CES functionality.(3) Deleted
test/Cloudy
, moved and renamed its content (test/Cloudy/runtests.jl
) toexamples/Cloudy/Cloudy_example.jl
. The Cloudy "test" never was a proper test but rather an example, so it fits much better in theexamples
folder. The Cloudy notebook (examples/Cloudy/calibrate_emulate_sample_Cloudy_demo.ipynb
) was deleted as it's basically just a more "eye-friendly" version ofCloudy_example.jl
.(4) Moved
GModel.jl
toexamples/Cloudy
. This module shows what a forward model G that maps the parameters u to G(u) could look like, but it does so using Cloudy as an example, and for that reason I never liked the fact that this module was there with all the general-purpose code in the first place. As a result of (3) and (4), there is no more Cloudy dependency in the tests or core CES code.(5) Generated separate
Project.toml
andManifest.toml
files for each example. With this setup, running the core CES code does not require to precompile packages that are only used in the examples (e.g.,DifferentialEquations.jl
) anymore.(6) Removed unused packages from the main
Project.toml
fileFinally, I also changed the way the
ScikitLearn.jl
imports are handled inGPEmulator.jl
. At least on my machine, this solves the problems with the seg faults that I mentioned in the discussion to PR #63.