More verbose naming #95
Conversation
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 85.19% 88.80% +3.61%
==========================================
Files 7 7
Lines 547 545 -2
==========================================
+ Hits 466 484 +18
+ Misses 81 61 -20
Continue to review full report at Codecov.
|
|
When running |
| @@ -77,6 +82,7 @@ using CalibrateEmulateSample.ParameterDistributionStorage | |||
| # Plot evolution of the EKI particles | |||
| eki_final_result = vec(mean(ekiobj.u[end], dims=1)) | |||
|
|
|||
| TEST_PLOT_OUTPUT = false | |||
There was a problem hiding this comment.
When running test/EnsembleKalmanProcesses/runtests.jl, it seems like TEST_PLOT_OUTPUT is not defined. Can you verify this behavior @odunbar ?
In theory we should run the tests as a block i.e from test/runtests.jl and so this is where TEST_PLOT_OUTPUT is defined (via a get method with 0 default if the CES_TEST_PLOT_OUTPUT variable is not defined). If you directly run the EKP block from test/EnsembleKalmanProcesses/runtests.jl you would need to define it.
So i would remove the line you've added here. Otherwise these run for me! Thanks!
There was a problem hiding this comment.
Edit: I've removed this in latest commit.
|
bors r+ |
|
Build succeeded: |
Purpose
To introduce more verbose naming conventions for filenames, modules and structs in the interest of more verbose naming conventions, as raised in Issue #82
Content
Name changes:
GPEmulatortoGaussianProcessEmulatorandGPObjtoGaussianProcessEKPtoEnsembleKalmanProcessesandEKObjtoEnsembleKalmanProcessMCMCtoMarkovChainMonteCarloandMCMCObjtoMCMCChanges made throughout:
Additional tests
It seems the current runtests for Utilities and EKP are below the required codecov standard, therefore I shall write some additional tests before the PR can be merged.
Coauthored with @ilopezgp