-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Diagnostics module #953
Conversation
eaf86d9
to
b1ef4ee
Compare
callbacks, | ||
dir_paths, | ||
turbulent_fluxes, | ||
thermo_params, | ||
amip_diags_handler, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to include amip_diags_handler
in the cs
object so we have access to it inside the coupling loop without creating a closure
11e7cbf
to
f88171d
Compare
7e02b0f
to
1557bfc
Compare
444c29c
to
8f8fd64
Compare
8d6ec54
to
a34252a
Compare
@@ -4,9 +4,11 @@ import Statistics | |||
import LinearAlgebra | |||
import ClimaAtmos as CA | |||
import ClimaAtmos: set_surface_albedo! | |||
import ClimaAtmos.Parameters as CAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these previously weren't being correctly imported but it wasn't caught because we were including files that did import these
cc7cdc5
to
91047be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me! Maybe I'd just add a section in the docs to discuss how to add new diagnostics and give some links to the example you added and to the docs for ClimaDiagnostics and ClimaAnalysis
experiments/ClimaEarth/components/atmosphere/climaatmos_extra_diags.jl
Outdated
Show resolved
Hide resolved
This generalizes the `make_ci_plots` function to `make_plots` which takes in variable names as an argument instead of hardcoding them within the function
The ClimaCoupler Diagnostics module had become redundant with ClimaDiagnostics.jl, a package designed to provide robust diagnostics across the CliMA ecosystem. Here we remove ClimaCoupler.Diagnostics and instead use ClimaDiagnostics. We're able to retrive most of the diagnostics we want directly from ClimaAtmos and ClimaLand, but also want some that come from coupler-computed quantities, such as `F_turb_energy`. In this PR we add this coupler quantity to our output diagnostics using the ClimaDiagnostics interface. This PR also removes the AMIP paperplots function, but this functionality is replaced by the generalized `make_plots` function.
b322309
to
e4bbc30
Compare
Purpose
Remove Diagnostics module in favor of ClimaDiagnostics and ClimaAnalysis
closes #954
will supersede #875 and #517
Content
This PR touches a lot of files, but most of it is just propagating a few main changes:
user_io/amip_diagnostics.jl
CoupledSimulation
object, which results in changes in many filesuser_io/ci_plots.jl
is generalized to meet the needs of our updated diagnostic plottingrun_name/artifacts/
, rather than an adjacent directoryrun_name_artifacts/
To-do
make_ci_plots
to work for AMIP plots as well; update amip_paperplots function to use thisclimaatmos_extra_diags.jl
amip_visualizer.jl
use_coupler_diagnostics
flagOutput checks
slabplanet_atmos_diags
now outputstoa_fluxes_net
, previous coupler-added atmos diagnostics, and default diagnostics from atmosF_turb_energy
Previous output: AMIP paperplots
New output:
atmos_summary_2D.pdf
atmos_summary_3D.pdf
(averaged over lon)coupler_summary_2D.pdf