-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zero instead of similar to avoid undefined behavior #346
Conversation
4d66a97
to
71ed4be
Compare
I hope that this can accelerate the bug hunting. |
Ok, good news, I'm pretty sure that in |
bf3d9c1
to
e5597ed
Compare
970d1db
to
5bf4068
Compare
5bf4068
to
2de0c29
Compare
Could you please run a ClimaAtmos test suite to verify that everything still works there? I think that this change will also implicitely raise the lower compat for ClimaCore in all our packages (to the version that contains the definion of zero). |
It works 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This will help prevent #283 and #301 from resurfacing for users.