Add support for ITime in IMEXAlgorithms and SSPKnoth #360
+38
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph-kev
force-pushed
the
kp/itime
branch
6 times, most recently
from
369265c to
7c39ce3
Compare
Sbozzolo
reviewed
Feb 3, 2025
src/arbitrary_number_types.jl
Outdated
| SciMLBase.allows_arbitrary_number_types(alg::T) | ||
| where {T <: ClimaTimeSteppers.IMEXAlgorithm} | ||
|
|
||
| Return `true`. Enable ARS343 to run with `ClimaUtilities.ITime`. |
There was a problem hiding this comment.
Suggested change
| Return `true`. Enable ARS343 to run with `ClimaUtilities.ITime`. | |
| Return `true`. Enable IMEXAlgorithms to run with `ClimaUtilities.ITime`. |
Sbozzolo
reviewed
Feb 3, 2025
| function tstops_and_saveat_heaps(t0, tf, tstops, saveat) | ||
| FT = typeof(tf) | ||
| function tstops_and_saveat_heaps(t0, tf, tstops, saveat = []) | ||
| FT = typeof(first(promote(t0, tf))) |
There was a problem hiding this comment.
Suggested change
| FT = typeof(first(promote(t0, tf))) | |
| # We promote to a common type to ensure that t0 and tf have the same type | |
| FT = typeof(first(promote(t0, tf))) |
|
|
||
| dt > zero(dt) || error("dt must be positive") | ||
| dt > zero(oneunit(dt)) || error("dt must be positive") |
There was a problem hiding this comment.
Suggested change
| dt > zero(oneunit(dt)) || error("dt must be positive") | |
| # We need zero(oneunit()) because there's no zerounit | |
| dt > zero(oneunit(dt)) || error("dt must be positive") |
src/solvers/imex_ark.jl
Outdated
| @@ -135,6 +135,10 @@ end | |||
| T_imp!(residual, U′, p, t_imp) | |||
| @. residual = temp + dtγ * residual - U′ | |||
| end | |||
| implicit_equation_jacobian! = (jacobian, Ui) -> begin | |||
There was a problem hiding this comment.
Is this block of code maybe result of a missing/incomplete rebase?
ph-kev
force-pushed
the
kp/itime
branch
3 times, most recently
from
38a52a2 to
53b2e81
Compare
Sbozzolo
changed the title
Sbozzolo
reviewed
Feb 3, 2025
NEWS.md
Outdated
| @@ -7,6 +7,7 @@ v0.8.2 | |||
| - ![][badge-💥breaking] If saveat is a number, then it does not automatically expand to `tspan[1]:saveat:tspan[2]`. To fix this, update | |||
| `saveat`, which is a keyword in the integrator, to be an array. For example, if `saveat` is a scalar, replace it with | |||
| `[tspan[1]:saveat:tspan[2]..., tspan[2]]` to achieve the same behavior as before. | |||
| - ARS343 and SSPKnoth are compatible with ITime. See ClimaUtilities for more information about ITime. | |||
There was a problem hiding this comment.
Suggested change
| - ARS343 and SSPKnoth are compatible with ITime. See ClimaUtilities for more information about ITime. | |
| - IMEXAlgorithms and SSPKnoth are compatible with ITime. See ClimaUtilities for more information about ITime. |
ph-kev
force-pushed
the
kp/itime
branch
3 times, most recently
from
c8a2f8d to
a959b8a
Compare
Sbozzolo
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ITime in ARS343 and SSPKnoth. This PR should be merged in after PR#347.
See this issue in ClimaUtilities for the remaining PRs to merge for ITime.