Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error hints #138

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add error hints #138

merged 1 commit into from
Dec 10, 2024

Conversation

ph-kev
Copy link
Member

@ph-kev ph-kev commented Dec 6, 2024

closes #94 - This PR adds error hints when using a function that depends on package being loaded.

Checklist

  • Verify that all the error hints work as intended

@ph-kev ph-kev marked this pull request as draft December 6, 2024 18:54
@ph-kev ph-kev requested a review from Sbozzolo December 6, 2024 22:53
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Sbozzolo
Copy link
Member

Sbozzolo commented Dec 9, 2024

Is something needed for ClimaCoreTempestRemap?

@ph-kev
Copy link
Member Author

ph-kev commented Dec 9, 2024

Is something needed for ClimaCoreTempestRemap?

I am not sure what is being asked here, but TempestRegridderneeds ClimaCoreTempestRemap to be loaded.

@Sbozzolo
Copy link
Member

Sbozzolo commented Dec 9, 2024

Is something needed for ClimaCoreTempestRemap?

I am not sure what is being asked here, but TempestRegridderneeds ClimaCoreTempestRemap to be loaded.

I didn't see the error hint for ClimaCoreTempestRemap, but now I do

@ph-kev ph-kev marked this pull request as ready for review December 10, 2024 17:56
@ph-kev ph-kev merged commit 1d114d3 into main Dec 10, 2024
26 of 27 checks passed
@ph-kev ph-kev deleted the kp/error-hints branch December 10, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error hints for extensions not loaded
2 participants