Add downstream tests #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/downstream
branch
6 times, most recently
from
0a6bbcc to
7836447
Compare
|
The test that is failing in ClimaLand doesn't have anything to do with ClimaUtilities... |
|
It would be nice to merge this - maybe we can just increase the tolerance for the land test |
Sbozzolo
force-pushed
the
gb/downstream
branch
2 times, most recently
from
d7a8378 to
4e13627
Compare
I don't understand how eps(FT) could be 1e-7. It is also quite annoying to debug this. The easiest way out is to increase the tolerance by one order of magntiude again, but this is not very satisfying solution |
Sbozzolo
force-pushed
the
gb/downstream
branch
5 times, most recently
from
07f718c to
6b27327
Compare
|
@juliasloan25 the issue with ClimaLand got fixed (it was |
juliasloan25
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45