Remove global allowscalar from testing suite attempt 2
#4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm so much in favor! I did try to do it one other time long ago and gave up... :( I'll help out! |
navidcy
added
testing 🧪
…ceananigans.jl into ss/remove-allowscalar-from-tests
|
So the output writer was failing with allow scalar operations and I added a Is this bad idea? |
|
I think so, this would defeat the purpose of this PR because it would not allow to catch scalar indexing issues with fields |
OK. But we need to do something because fetch_output was hitting a wall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it does not allow us to catch problems where kernels erroneously run on the CPU (for example #4036), see CliMA/ClimaOcean.jl#318 (comment)
Probably will require a bit of fiddling to add
allowscalargranularly in testscloses #3039