Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tzdata to Docker #22000

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Add tzdata to Docker #22000

merged 3 commits into from
Mar 24, 2021

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Build/Testing/Packaging improvement.

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add tzdata to Docker containers because reading ORC formats requires it. This closes #14156.

Detailed description / Documentation draft:
A note to @filimonov: you can add it to Alpine images if you want.

@filimonov filimonov self-requested a review March 23, 2021 06:33
@filimonov filimonov self-assigned this Mar 23, 2021
Copy link
Contributor

@filimonov filimonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% happy with that: now we got 2 sources of truth for tzdata - one installed in the system and used by orc parser (and who know by what 3rd party else), and one embedded and used by the rest.

But ok (since alternative - to patch that an that is more complicated).

&& apk add --no-cache su-exec bash \
&& apk add --no-cache su-exec bash tzdata \
&& cp /usr/share/zoneinfo/UTC /etc/localtime \
&& echo "UTC" > /etc/timezone \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexey-milovidov
Copy link
Member Author

#22094.

@alexey-milovidov alexey-milovidov merged commit b6a0f2f into master Mar 24, 2021
@alexey-milovidov alexey-milovidov deleted the docker-add-tzdata branch March 24, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orc requires tzdata: 'orc::getLocalTimezone(): Can't open /etc/localtime."
2 participants