Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clashed columns from totals for StorageJoin #23549

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented Apr 23, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Apr 23, 2021
@vdimir
Copy link
Member Author

vdimir commented Apr 23, 2021

We are skipping such columns in AddedColumns, but not in joinTotals

/// Don't insert column if it's in left block
if (!block.has(src_column.name))
addColumn(src_column);

@alexey-milovidov alexey-milovidov self-assigned this Apr 24, 2021
@alexey-milovidov alexey-milovidov merged commit ca23022 into ClickHouse:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default pr-no-backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in query with join and 'with totals' clause
3 participants