Common system metrics collection #24416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m .h; another small fixes
… "readField" method
robot-clickhouse
added
doc-alert
pr-feature
|
Lots of environments already have such monitoring, looks like it worth adding a configuration directive to control these new collectors, and make it OFF by default? Also maybe it worth looking at some existing tools (most popular these days I guess is node exporter) to make these metrics compatible? |
|
@azat What is the reason for turning these metrics off? The scenario is when a server collected these metrics for a year and at least once these metrics will save a day. |
|
|
|
Perf test Ok (the column has been renamed and the new name does not exist in old version). |
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jul 16, 2021
Since in ClickHouse#24416 asynchronous_metrics_update_period_s had been set to 1 and this became annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Collect common system metrics (in
system.asynchronous_metricsandsystem.asynchronous_metric_log) about CPU usage, disk usage, memory usage, IO, network, files, load average, CPU frequencies, thermal sensors, EDAC counters, system uptime; also added metrics about the scheduling jitter and the time spent collecting the metrics. It works likeatopin ClickHouse and allows to get monitoring data even if you have no additional tools installed. This closes #9430.