Fix selecting with extremes from LowCardinality(UUID) #27918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
vitlibar
commented
Aug 20, 2021
| @@ -304,7 +304,7 @@ size_t ColumnUnique<ColumnType>::uniqueInsert(const Field & x) | |||
| if (x.getType() == Field::Types::Null) | |||
| return getNullValueIndex(); | |||
|
|
|||
| if (isNumeric()) | |||
| if (valuesHaveFixedSize()) | |||
| return uniqueInsertData(&x.reinterpret<char>(), size_of_value_if_fixed); | |||
|
|
|||
| auto & val = x.get<String>(); | |||
There was a problem hiding this comment.
Without my fix this line produced a logical error:
<Fatal> : Logical error: 'Invalid Field get from type UUID to type String'.
alexey-milovidov
approved these changes
Aug 21, 2021
This was referenced Aug 21, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 21, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 21, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 21, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 21, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 21, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Aug 21, 2021
Backport #27918 to 21.9: Fix selecting with extremes from LowCardinality(UUID)
vitlibar
pushed a commit
that referenced
this pull request
Aug 23, 2021
vitlibar
pushed a commit
that referenced
this pull request
Aug 23, 2021
vitlibar
pushed a commit
that referenced
this pull request
Aug 23, 2021
vitlibar
pushed a commit
that referenced
this pull request
Aug 23, 2021
vitlibar
pushed a commit
that referenced
this pull request
Aug 24, 2021
Backport #27918 to 21.8: Fix selecting with extremes from LowCardinality(UUID)
vitlibar
pushed a commit
that referenced
this pull request
Aug 24, 2021
Backport #27918 to 21.7: Fix selecting with extremes from LowCardinality(UUID)
vitlibar
pushed a commit
that referenced
this pull request
Aug 24, 2021
Backport #27918 to 21.6: Fix selecting with extremes from LowCardinality(UUID)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
Changelog entry:
Fix selecting with extremes from a column of the type
LowCardinality(UUID)