-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix getNumberOfArguments() for s2Rect functions #28663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Sep 6, 2021
cc: @nikitamikhaylov |
Thanks @bharatnc ! |
nikitamikhaylov
approved these changes
Sep 6, 2021
I'll see if I can open another PR later to add some tests for the s2Rect functions. |
This fixes the value returned by the getNumberOfArguments() by the s2RectAdd and the s2RectContains functions. Only 3 arguments are used by these functions and not 4: - low s2Point of rectangle - high s2Point of rectangle - given s2Point The given s2Point is used to groow the size of the bounding rectangle to include the given S2Point in case of the s2RectAdd function. In case of s2RectContains, the function determines if the bounded rectangle contains the given point. PS: I wonder if it's more apt to call rectAdd as rectGrow since it's used to grow the size of a given rectangle.
This was referenced Sep 7, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 7, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Sep 8, 2021
Backport #28663 to 21.9: fix getNumberOfArguments() for s2Rect functions
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 9, 2021
nikitamikhaylov
added a commit
that referenced
this pull request
Sep 10, 2021
Backport #28663 to 21.10: fix getNumberOfArguments() for s2Rect functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Detailed description / Documentation draft:
This fixes the value returned by the
getNumberOfArguments()
by thes2RectAdd
and thes2RectContains
functions. Only3
arguments areused by these functions and not
4
:The given s2Point is used to groow the size of the bounding rectangle to
include the given S2Point in case of the
s2RectAdd
function. In caseof
s2RectContains
, the function determines if the bounded rectanglecontains the given point.
PS: I wonder if it's more apt to call
rectAdd
asrectGrow
sinceit's used to grow the size of a given rectangle.