-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make index or partition filter valid in tuple like (k1, k2)=(v1,v2)
#29281
Conversation
You have a great example in your issue, let's try to add it as test. Also there's some commits |
@vdimir Thanks for your reviewing ! I will try to add some tests and rebase the unnecessary commits. |
97c991f
to
9acf05c
Compare
@lingtaolf I guess you can / should use "force..." for tests:
--force_index_by_date arg Throw an exception if there is a partition key in a table, and it is not used. |
@den-crane Done ! Thanks for you advices . |
I fixed fuzzer error and added support both type of expressions Analyzing of expression like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your changes!
Let's wait for CI and merge if it'll be ok.
@vdimir Thanks for your help ! |
CI stuck for some reason, I'm going to rebase branch |
6ab91d1
to
ce844e4
Compare
ce844e4
to
7444d64
Compare
Added a couple of testcases with tuple in tuple and rebase on master, hope final change, will wait CI and merge. |
Known solved issue |
Fixes: ClickHouse#29281 Fixes: test_cluster_copier/test_three_nodes.py::test
@vdimir @lingtaolf |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Primary key index and partition filter can work in tuple
This PR solved problem in #29269