Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update poco to fix GCS via proxy tunnel usage #38726

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

azat
Copy link
Member

@azat azat commented Jul 2, 2022

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix GCS via proxy tunnel usage

GCS server does not handle requests with port, and simply report an
error:

    <?xml version="1.0"?>
    <?xml version='1.0' encoding='UTF-8'?>
    <Error>
        <Code>InvalidURI</Code>
        <Message>Couldn't parse the specified URI.</Message>
        <Details>Invalid URL: storage.googleapis.com:443/...</Details>
    </Error>

Removing the port fixes the issue. Note that there is port in the Host
header anyway.

Note, this is a problem only for proxy in a tunnel mode, since only it
sends such requests, other sends requests directly via HTTP methods.

Refs: ClickHouse/poco#22 (comment) (cc @Jokser)
Requires: ClickHouse/poco#63
Refs: #38069 (cc @CurtizJ)
Cc: @alesapin @kssenii

Note: marked as Draft since it uses HEAD from the required pull request, not MERGE_HEAD

@robot-ch-test-poll robot-ch-test-poll added pr-improvement Pull request with some product improvements submodule changed At least one submodule changed in this PR. labels Jul 2, 2022
@azat azat marked this pull request as draft July 2, 2022 08:28
GCS server does not handle requests with port, and simply report an
error:

```xml
    <?xml version="1.0"?>
    <?xml version='1.0' encoding='UTF-8'?>
    <Error>
        <Code>InvalidURI</Code>
        <Message>Couldn't parse the specified URI.</Message>
        <Details>Invalid URL: storage.googleapis.com:443/...</Details>
    </Error>
```

Removing the port fixes the issue. Note that there is port in the Host
header anyway.

Note, this is a problem only for proxy in a tunnel mode, since only it
sends such requests, other sends requests directly via HTTP methods.

Refs: ClickHouse/poco#22 (comment) (cc @Jokser)
Refs: ClickHouse/poco#63
Refs: ClickHouse#38069 (cc @CurtizJ)
Cc: @alesapin @kssenii

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat azat force-pushed the proxy-fix-for-GCS branch from ae67bd5 to cd2d053 Compare July 4, 2022 05:46
@azat azat marked this pull request as ready for review July 4, 2022 05:46
@alexey-milovidov alexey-milovidov self-assigned this Jul 4, 2022
@alexey-milovidov alexey-milovidov merged commit 88539d6 into ClickHouse:master Jul 4, 2022
@azat azat deleted the proxy-fix-for-GCS branch July 5, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants