Include fixes #454
Merged
Include fixes #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
requested changes
Feb 7, 2017
| @@ -5,7 +5,7 @@ | |||
| #include <DB/Storages/IStorage.h> | |||
|
|
|||
|
|
|||
| namespace Poco { class Logger; } | |||
| using Poco::Logger; | |||
There was a problem hiding this comment.
Why we need to put Logger to global namespace in header file?
| @@ -7,6 +7,9 @@ | |||
| * Example: Int8(-1) != UInt8(255) | |||
| */ | |||
|
|
|||
|
|
|||
| using DB::UInt64; | |||
|
|
||
| namespace Poco { class Logger; } | ||
| using Poco::Logger; |
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Aug 15, 2023
liuneng1994
pushed a commit
to liuneng1994/ClickHouse
that referenced
this pull request
Aug 18, 2023
binmahone
pushed a commit
to binmahone/ClickHouse
that referenced
this pull request
Aug 25, 2023
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Aug 31, 2023
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Sep 12, 2023
binmahone
pushed a commit
to binmahone/ClickHouse
that referenced
this pull request
Sep 20, 2023
liuneng1994
pushed a commit
to liuneng1994/ClickHouse
that referenced
this pull request
Sep 21, 2023
binmahone
pushed a commit
to binmahone/ClickHouse
that referenced
this pull request
Sep 25, 2023
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Oct 12, 2023
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Nov 6, 2023
lgbo-ustc
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Nov 20, 2023
lgbo-ustc
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Nov 24, 2023
lgbo-ustc
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Nov 27, 2023
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Dec 5, 2023
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Dec 6, 2023
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Dec 18, 2023
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Dec 19, 2023
lgbo-ustc
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Dec 25, 2023
…writing (ClickHouse#454) (cherry picked from commit b306260)
lgbo-ustc
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Dec 26, 2023
…writing (ClickHouse#454) (cherry picked from commit b306260)
loneylee
pushed a commit
to loneylee/ClickHouse
that referenced
this pull request
Jan 2, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260) (cherry picked from commit 92b51e5)
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Jan 11, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260) (cherry picked from commit 92b51e5) (cherry picked from commit e286118)
liuneng1994
pushed a commit
to liuneng1994/ClickHouse
that referenced
this pull request
Jan 16, 2024
liuneng1994
pushed a commit
to liuneng1994/ClickHouse
that referenced
this pull request
Feb 27, 2024
baibaichen
pushed a commit
to baibaichen/ClickHouse
that referenced
this pull request
Mar 8, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260) (cherry picked from commit 92b51e5) (cherry picked from commit e286118) (cherry picked from commit 2fd30ba) (cherry picked from commit 70872d4) (cherry picked from commit e4272cf) (cherry picked from commit 2a162aa) (cherry picked from commit 5ce59c2)
liuneng1994
pushed a commit
to liuneng1994/ClickHouse
that referenced
this pull request
Mar 18, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260) (cherry picked from commit 92b51e5) (cherry picked from commit e286118) (cherry picked from commit 2fd30ba) (cherry picked from commit 70872d4) (cherry picked from commit e4272cf) (cherry picked from commit 2a162aa) (cherry picked from commit 5ce59c2) (cherry picked from commit d705a83)
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Mar 25, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260) (cherry picked from commit 92b51e5) (cherry picked from commit e286118) (cherry picked from commit 2fd30ba) (cherry picked from commit 70872d4) (cherry picked from commit e4272cf) (cherry picked from commit 2a162aa) (cherry picked from commit 5ce59c2)
liuneng1994
pushed a commit
to liuneng1994/ClickHouse
that referenced
this pull request
May 17, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260) (cherry picked from commit 92b51e5) (cherry picked from commit e286118) (cherry picked from commit 2fd30ba) (cherry picked from commit 70872d4) (cherry picked from commit e4272cf) (cherry picked from commit 2a162aa) (cherry picked from commit 5ce59c2) (cherry picked from commit d705a83) (cherry picked from commit 04e46db) (cherry picked from commit 3d0ebdd) (cherry picked from commit 13448f2) (cherry picked from commit 616c93a) (cherry picked from commit a27fce6)
liuneng1994
pushed a commit
to liuneng1994/ClickHouse
that referenced
this pull request
May 28, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260)
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Jun 7, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260)
taiyang-li
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Jun 17, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260)
liuneng1994
pushed a commit
to liuneng1994/ClickHouse
that referenced
this pull request
Jun 24, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260)
liuneng1994
pushed a commit
to liuneng1994/ClickHouse
that referenced
this pull request
Jul 9, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260)
liuneng1994
pushed a commit
to liuneng1994/ClickHouse
that referenced
this pull request
Jul 16, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260)
lgbo-ustc
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Jul 29, 2024
…writing (ClickHouse#454) (cherry picked from commit b306260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.