Fix mbm with aio on top of query plan #45892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-improvement
nickitat
force-pushed
the
fix_mbm_with_aio_on_top_of_query_plan
branch
from
be63bb4
to
b39a653
Compare
nickitat
commented
Feb 2, 2023
nickitat
force-pushed
the
fix_mbm_with_aio_on_top_of_query_plan
branch
from
e82c5e5
to
a4cee17
Compare
nickitat
force-pushed
the
fix_mbm_with_aio_on_top_of_query_plan
branch
from
5c523ba
to
74c7816
Compare
nickitat
force-pushed
the
fix_mbm_with_aio_on_top_of_query_plan
branch
from
74c7816
to
8a14081
Compare
devcrafter
reviewed
Feb 10, 2023
| WHERE query_id IN (SELECT query_id FROM system.query_log WHERE query_id != '$1' AND initial_query_id = '$1' AND event_date >= yesterday()) | ||
| AND event_date >= yesterday() AND logger_name = 'MergeTreeInOrderSelectProcessor'" | ||
| } | ||
|
|
There was a problem hiding this comment.
It'd be nice to have comments what exactly the tests are checking
| SELECT URL, EventDate, max(URL) | ||
| FROM remote(test_cluster_one_shard_two_replicas, test.hits) | ||
| WHERE CounterID = 1704509 AND UserID = 4322253409885123546 | ||
| GROUP BY CounterID, URL, EventDate, EventDate |
There was a problem hiding this comment.
Suggested change
| GROUP BY CounterID, URL, EventDate, EventDate | |
| GROUP BY CounterID, URL, EventDate |
devcrafter
reviewed
Feb 10, 2023
| SELECT URL, EventDate, max(URL) | ||
| FROM remote(test_cluster_one_shard_two_replicas, test.hits) | ||
| WHERE CounterID = 1704509 AND UserID = 4322253409885123546 | ||
| GROUP BY URL, EventDate, EventDate |
There was a problem hiding this comment.
Suggested change
| GROUP BY URL, EventDate, EventDate | |
| GROUP BY URL, EventDate |
|
wow, all green ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Improved how memory bound merging and aggregation in order on top query plan interact. Previously we fell back to explicit sorting for AIO in some cases when it wasn't actually needed. So it is a perf issue, not a correctness one.
Documentation entry for user-facing changes
When initiator choses AIO it sends special setting
force_aggregation_in_orderto remote nodes. Previously it led to insertion of explicit sorting step into the plan ifgroup_by_info == nullptr(e.g. whenquery_plan_aggregation_in_order == true). In this case optimisation on top of plan wasn't applied because it doesn't expectSortingStepin betweenAggregatingStepandRead*Step. It led to not using reading in order and we were need to sort explicitly.Now we will not insert
SortingStep(sorting transforms will be added byAggregatingStepif needed) and should correctly initiate reading in order.