Refactoring of virtual columns #60205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ClickHouse into refactor-virtual-columns
robot-ch-test-poll2
added
the
pr-improvement
|
This is an automated comment for commit c887833 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
CurtizJ
force-pushed
the
refactor-virtual-columns
branch
from
8889a70 to
0fa22ab
Compare
1 task
CurtizJ
force-pushed
the
refactor-virtual-columns
branch
from
dd400de to
1b9e6c9
Compare
jkartseva
approved these changes
Mar 5, 2024
Comment on lines
-356
to
-126
| NamesAndTypesList result_virtuals; | ||
| std::set_difference( | ||
| default_virtuals.begin(), default_virtuals.end(), storage_columns.begin(), storage_columns.end(), | ||
| std::back_inserter(result_virtuals), | ||
| [](const NameAndTypePair & lhs, const NameAndTypePair & rhs){ return lhs.name < rhs.name; }); |
There was a problem hiding this comment.
So, the lexicographical order is guaranteed by the VirtualColumnsDescription::Container ? Looks nice!
There was a problem hiding this comment.
It's not guaranteed, but it's not needed either.
Comment on lines
+39
to
+40
| auto it = container.get<1>().find(name); | ||
| if (it != container.get<1>().end() && (static_cast<UInt8>(it->kind) & static_cast<UInt8>(kind))) |
There was a problem hiding this comment.
In general I don't like it and here it will be more cumbersome, I think.
Comment on lines
-1408
to
+1411
| if (all_columns.has(command.column_name) || | ||
| all_columns.hasNested(command.column_name) || | ||
| (command.clear && column_name == LightweightDeleteDescription::FILTER_COLUMN.name)) | ||
| if (all_columns.has(command.column_name) || all_columns.hasNested(command.column_name)) |
There was a problem hiding this comment.
Was the condition command.clear && column_name == LightweightDeleteDescription::FILTER_COLUMN.name) superfluous?
There was a problem hiding this comment.
Yes, it was superfluous. It was never satisfied because the query always fails earlier and it's the expected behaviour, I think.
| : DB::IStorageSystemOneBlock<StorageSystemDictionaries>(storage_id_) | ||
| { | ||
| VirtualColumnsDescription virtuals; | ||
| virtuals.addEphemeral("key", std::make_shared<DataTypeString>(), ""); |
There was a problem hiding this comment.
Not related to the diff, but seems that the name "key" violates the naming convention for virtual columns?
There was a problem hiding this comment.
Yes, but let's not introduce backward incompatibility.
robot-ch-test-poll2
added
the
pr-synced-to-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Improved overall usability of virtual columns. Now it is allowed to use virtual columns in
PREWHERE(it's worthwhile for non-const virtual columns like_part_offset). Now a builtin documentation is available for virtual columns as a comment of column inDESCRIBEquery with enabled settingdescribe_include_virtual_columns.Includes #59033.
Fixes #60685.