-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert revert of "Fix wacky primary key sorting in SHOW INDEX
"
#61131
Merged
rschu1ze
merged 4 commits into
ClickHouse:master
from
rschu1ze:revert-revert-show-index-sorting
Jul 18, 2024
Merged
Revert revert of "Fix wacky primary key sorting in SHOW INDEX
"
#61131
rschu1ze
merged 4 commits into
ClickHouse:master
from
rschu1ze:revert-revert-show-index-sorting
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-2
added
the
pr-improvement
Pull request with some product improvements
label
Mar 10, 2024
Contributor
This is an automated comment for commit 6785240 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
This comment was marked as outdated.
This comment was marked as outdated.
alexey-milovidov
approved these changes
Jul 17, 2024
Merged
via the queue into
ClickHouse:master
with commit Jul 18, 2024
3c2c5b3
186 of 193 checks passed
robot-ch-test-poll4
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-improvement
Pull request with some product improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-submit of #60514 which was reverted with #60898. It includes the original fix plus a fix for the problem broke DatabaseReplicated tests in CI.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The result of
SHOW INDEX | INDEXES | INDICES | KEYS
was previously sorted by the primary key column names. Since this was unintuitive, the result is now sorted by the position of the primary key columns within the primary key.