-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable plain_rewritable metadata for local
and azure
object storages
#63365
Merged
jkartseva
merged 3 commits into
ClickHouse:master
from
jkartseva:support-generic-disk-s3-plain-rw
May 7, 2024
Merged
Enable plain_rewritable metadata for local
and azure
object storages
#63365
jkartseva
merged 3 commits into
ClickHouse:master
from
jkartseva:support-generic-disk-s3-plain-rw
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkartseva
added
the
can be tested
Allows running workflows for external contributors
label
May 4, 2024
robot-ch-test-poll4
added
the
pr-improvement
Pull request with some product improvements
label
May 4, 2024
Contributor
This is an automated comment for commit fcad15f with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
jkartseva
force-pushed
the
support-generic-disk-s3-plain-rw
branch
from
May 4, 2024 05:05
e7a219d
to
18efeca
Compare
jkartseva
force-pushed
the
support-generic-disk-s3-plain-rw
branch
6 times, most recently
from
May 7, 2024 03:47
5e826d0
to
d051655
Compare
Enable plain_rewritable support for local and azure (azure_blob_storage) metadata type. - HDFS object storage currently does not support iteration and does not implement listObjects method. It's a blocker for enabling plain_rewritable metadata type with HDFS. - StaticWeb object storage is read-only and works with its dedicated metadata type.
jkartseva
force-pushed
the
support-generic-disk-s3-plain-rw
branch
from
May 7, 2024 03:53
d051655
to
fcad15f
Compare
kssenii
approved these changes
May 7, 2024
/// TODO(jkartseva@): Test support for generic disk type | ||
if (type != ObjectStorageType::S3) | ||
throw Exception(ErrorCodes::NOT_IMPLEMENTED, "plain_rewritable metadata storage support is implemented only for S3"); | ||
/// HDFS object storage currently does not support iteration and does not implement listObjects method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI, listObjects for hdfs object storage is added in #59767, so this can be adjusted afterwards.
Merged
via the queue into
ClickHouse:master
with commit May 7, 2024
fc9fa70
228 of 231 checks passed
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-improvement
Pull request with some product improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Enable plain_rewritable metadata for local and Azure (azure_blob_storage) object storages.
Documentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: