-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bug at hash dictionary short circuit #65256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsc0218
added
can be tested
Allows running workflows for external contributors
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
labels
Jun 14, 2024
robot-ch-test-poll3
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jun 14, 2024
Contributor
This is an automated comment for commit d32647a with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Merged
via the queue into
ClickHouse:master
with commit Jun 14, 2024
d58ae3c
82 of 143 checks passed
robot-ch-test-poll3
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Jun 14, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Jun 14, 2024
This was referenced Jun 14, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Jun 14, 2024
This was referenced Jun 14, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Jun 14, 2024
This was referenced Jun 14, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Jun 14, 2024
robot-clickhouse
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Jun 14, 2024
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jun 14, 2024
Backport #65256 to 24.3: Fix the bug at hash dictionary short circuit
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Jun 14, 2024
Backport #65256 to 24.4: Fix the bug at hash dictionary short circuit
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Jun 14, 2024
Backport #65256 to 24.5: Fix the bug at hash dictionary short circuit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works okay in the latest master, so would change code at old branches.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix the bug in Hashed and Hashed_Array dictionary short circuit evaluation, which may read uninitialized number, leading to various errors.
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):