-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite recursion when infering a proto schema with skip unsupported fields enabled #70697
Merged
alexey-milovidov
merged 1 commit into
ClickHouse:master
from
Algunenano:recursive_proto_skip_fields
Oct 16, 2024
Merged
Fix infinite recursion when infering a proto schema with skip unsupported fields enabled #70697
alexey-milovidov
merged 1 commit into
ClickHouse:master
from
Algunenano:recursive_proto_skip_fields
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rted fields enabled
robot-ch-test-poll4
added
pr-critical-bugfix
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
labels
Oct 15, 2024
Contributor
This is an automated comment for commit 94c6fab with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
alexey-milovidov
approved these changes
Oct 16, 2024
Thanks! We can also use depth-counting and |
This was referenced Oct 16, 2024
robot-ch-test-poll1
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Oct 16, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Oct 16, 2024
…180ca42f2f8c33b8d70b106b864df Cherry pick #70697 to 24.7: Fix infinite recursion when infering a proto schema with skip unsupported fields enabled
robot-clickhouse
added a commit
that referenced
this pull request
Oct 16, 2024
… schema with skip unsupported fields enabled
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Oct 16, 2024
…180ca42f2f8c33b8d70b106b864df Cherry pick #70697 to 24.8: Fix infinite recursion when infering a proto schema with skip unsupported fields enabled
robot-clickhouse
added a commit
that referenced
this pull request
Oct 16, 2024
… schema with skip unsupported fields enabled
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Oct 16, 2024
…180ca42f2f8c33b8d70b106b864df Cherry pick #70697 to 24.9: Fix infinite recursion when infering a proto schema with skip unsupported fields enabled
robot-clickhouse
added a commit
that referenced
this pull request
Oct 16, 2024
… schema with skip unsupported fields enabled
robot-ch-test-poll
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Oct 16, 2024
robot-ch-test-poll1
added a commit
that referenced
this pull request
Oct 16, 2024
Backport #70697 to 24.9: Fix infinite recursion when infering a proto schema with skip unsupported fields enabled
robot-clickhouse
added a commit
that referenced
this pull request
Oct 16, 2024
Backport #70697 to 24.8: Fix infinite recursion when infering a proto schema with skip unsupported fields enabled
robot-ch-test-poll1
added a commit
that referenced
this pull request
Oct 16, 2024
Backport #70697 to 24.7: Fix infinite recursion when infering a proto schema with skip unsupported fields enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-critical-bugfix
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix infinite recursion when infering a proto schema with skip unsupported fields enabled
The problem was that when skipping an unsupported field due to type recursion (supported in protobuf but not in CH type system) we didn't keep track of it anymore, so we would try to resolve it again and again. This would not happen with default settings (no skip unsupported) because an exception would be thrown in the first occurence.
Closes #70630
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):